Allow copy of date objects #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should use SSLContext.load_default_certs to load system CAs properly on all platforms including Windows. SSLContext.set_default_verify_paths worked fine on Linux based OSes. load_default_certs is new in Python 3.4.
Proper initialization of system CAs on Windows
During rolling upgrades of clusters the handshake can be interrupted and a read during handshake can fail, this should be retried. Change the exception raised for this condition.
These errors from server should trigger a retry: Neo.ClientError.Cluster.NotALeader Neo.ClientError.General.ForbiddenOnReadOnlyDatabase
…to allow-copy-of-date-objects � Conflicts: � neo4j/io/_bolt4x1.py � neo4j/io/_courier.py
|
Thanks for your proposed change, @stellasia! Looks good to me. Please take the time to sign our CLA. Currently, the pipelines are a little unstable. Once I've fixed that and you've signed the CLA, I'll happily merge this PR. |
|
CLA signed :) I do not have access to the TeamCity workflow, I don't know if it is related to the pipeline failure. |
|
Yes, the pipelines are built to fail if the CLA is not signed. All green now. Thanks again 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to fix #523